Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QtPropertyBrowser: resizeToContent(), bold property text, read-only handling #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

spacegaier
Copy link
Contributor

@spacegaier spacegaier commented Feb 20, 2019

  • New method resizeToContet() to allow resizing to display as much content as possible to the user, while still having the option to set the overall resize mode to e.g. "QHeaderView::Interactive".
  • Read-only functionality for enum property manager
  • Bold text option for property

…o display as much content as possible to the user, while still having the option to set the overall resize mode to e.g. "QHeaderView::Interactive"
…old font. Beneficial for highlighting or providing additional visual structure for group / parent properties
@spacegaier spacegaier changed the title QtPropertyBrowser: New method "resizeToContent()" ... QtPropertyBrowser: resizeToContent(), bold property text, read-only handling Feb 21, 2019
@spacegaier
Copy link
Contributor Author

BTW: I am aware of the Qt Contribution Guidelines but have no time currently to work through that complex process (at least I remember it that way from last time I did a few years ago).
Thought I leave the PR here for now, incase someone else has a use for the proposed changes.

@@ -1543,7 +1543,7 @@ void QtStringPropertyManager::setReadOnly(QtProperty *property, bool readOnly)
it.value() = data;

emit propertyChanged(property);
emit readOnlyChanged(property, data.readOnly);
emit readOnlyChanged(property, data.echoMode);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh? Is this correct?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants