Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Therese Reisch, Tara Neufell, Kevin Buck bash project - Bioinformatics #3

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

treisch1
Copy link

No description provided.

for index in {01..22}
do cat ref_sequences/hsp70gene_$index.fasta >> ref_sequences/hsp70master.fasta
done

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

#aligning reference files using muscle tool
~/Private/biocomputing2022/tools/muscle -in ref_sequences/mcrAmaster.fasta -out ref_sequences/mcrAmaster.aligned
~/Private/biocomputing2022/tools/muscle -in ref_sequences/hsp70master.fasta -out ref_sequences/hsp70master.aligned

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+3

#build hidden markov model with hmmer tool
~/Private/biocomputing2022/tools/hmmbuild ref_sequences/mcrAmaster.build ref_sequences/mcrAmaster.aligned
~/Private/biocomputing2022/tools/hmmbuild ref_sequences/hsp70master.build ref_sequences/hsp70master.aligned

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+3

for index in {01..50}
do ~/Private/biocomputing2022/tools/hmmsearch --tblout proteomes/proteome$index.hsp70search ref_sequences/hsp70master.build proteomes/proteome_$index.fasta
done

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

hsp70count=$(grep -v -c "#" proteomes/proteome$index.hsp70search)
echo "proteome_$index, $mcrAcount, $hsp70count" >> proteomecounttable.txt
done

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+4

touch recommendationslist.txt
echo proteome_name, mcrA_count, hsp70_count >> recommendationslist.txt
cat proteomecounttable.txt | grep -E ", [1|2]," | sort -t , -k 3 -n -r >> recommendationslist.txt

Copy link
Owner

@qtran4 qtran4 Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-header comments, including usage line [1 point]
-general commenting of code throughout script [1 point]
-code efficiency [1 points]

=> 1 point was taken off since you don't need the for loop for lines 7-14
You can also make a for loop for hmm search for both Hsp and mcrA, as well as outputting the table form in just one for loop.

@@ -0,0 +1,51 @@
proteome_name, mcrA_count, hsp70_count
proteome_01, 0, 4
proteome_02, 0, 1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be proteome_02, 0, 2

proteome_14, 0, 1
proteome_15, 1, 1
proteome_16, 1, 1
proteome_17, 0, 4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 0, 4

proteome_37, 0, 1
proteome_38, 1, 1
proteome_39, 1, 1
proteome_40, 0, 1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 0, 2

proteome_43, 0, 3
proteome_44, 1, 1
proteome_45, 1, 3
proteome_46, 0, 1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 0, 2

Copy link
Owner

@qtran4 qtran4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+20
Some values in the result tale do not match the answer and I still don't know why.
Still give you full mark on this though

for index in {01..22}
do cat ref_sequences/hsp70gene_$index.fasta >> ref_sequences/hsp70master.fasta
done

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need one line for this
cat ref_sequences/mcrAgene_* > ref_sequences/ref_mcrAgenes.fasta
same for hsp70

Copy link
Owner

@qtran4 qtran4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants