Skip to content

Commit

Permalink
Clean up deprecations (#156)
Browse files Browse the repository at this point in the history
* Pydantic v2 upgrade

* Unused imports
  • Loading branch information
gazwald authored Nov 1, 2023
1 parent 2a34662 commit a841222
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 16 deletions.
2 changes: 0 additions & 2 deletions master/protocols/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import logging

from master.protocols.decoder import Decoder
from master.protocols.models import ALL_ACTIVE_PROTOCOLS, GameProtocol
from master.protocols.models.response import ProtocolResponse
Expand Down
4 changes: 2 additions & 2 deletions master/protocols/decoder.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ def decode(self, data: bytes) -> dict:
return result

def generate_protocol_response(self, data: bytes) -> ProtocolResponse:
response = self.decode(data)
return ProtocolResponse.parse_obj(response)
response: dict = self.decode(data)
return ProtocolResponse.model_validate(response, strict=True)

def _generate_metadata(self) -> ResultTypeDict:
"""
Expand Down
6 changes: 2 additions & 4 deletions master/protocols/models/base.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
from collections.abc import Mapping
from typing import Literal, Optional

from pydantic import BaseModel, Field # pylint: disable=no-name-in-module
from pydantic import BaseModel, ConfigDict, Field # pylint: disable=no-name-in-module


class BaseProtocol(BaseModel):
class Config:
str_strip_whitespace = True
model_config = ConfigDict(str_strip_whitespace=True)


class BaseProtocolHeader(BaseModel):
Expand Down
2 changes: 0 additions & 2 deletions master/protocols/models/idtech1/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
from pydantic import Field

from master.protocols.models import GameProtocol
from master.protocols.models.response import ProtocolResponse

Expand Down
1 change: 0 additions & 1 deletion master/server/handlers/healthcheck.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import logging
from socketserver import StreamRequestHandler

PROTOCOL: str = "HTTP/1.1"
Expand Down
4 changes: 2 additions & 2 deletions master/storage/backends/dynamodb.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def get_server(self, address: str, game: str | None = None) -> Server | None:
result: Item | None = self._query_item(address, game)

if result:
server = Server.parse_obj(result)
server = Server.model_validate(result, strict=True)

return server

Expand All @@ -124,7 +124,7 @@ def get_servers(self, game: str | None = None) -> list[Server]:

result = self._scan(game)
for server in result:
servers.append(Server.parse_obj(server))
servers.append(Server.model_validate(server, strict=True))

return servers

Expand Down
5 changes: 2 additions & 3 deletions master/storage/models/server.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
from pydantic import BaseModel, Field # pylint: disable=no-name-in-module
from pydantic import BaseModel, ConfigDict, Field # pylint: disable=no-name-in-module


class Server(BaseModel):
class Config:
str_strip_whitespace = True
model_config = ConfigDict(str_strip_whitespace=True)

address: str = Field(
description="Colon separated tuple of the server IP address and port, e.g.: <IP>:<PORT>"
Expand Down

0 comments on commit a841222

Please sign in to comment.