Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated a bit in the description, included readme updates #4

Merged
merged 7 commits into from
Nov 28, 2023

Conversation

christopherDT
Copy link
Contributor

@dhhagan please review, let me know if you'd like more information for the relevant README sections

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0e0dedc) 64.41% compared to head (16c35c5) 64.63%.

❗ Current head 16c35c5 differs from pull request most recent head f19bb7e. Consider uploading reports for the commit f19bb7e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   64.41%   64.63%   +0.21%     
==========================================
  Files           3        3              
  Lines         163      164       +1     
==========================================
+ Hits          105      106       +1     
  Misses         58       58              
Files Coverage Δ
R/api_calls.R 85.18% <100.00%> (+0.27%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christopherDT
Copy link
Contributor Author

@dhhagan awaiting review, let me know if I can fix the PR somehow -- looks like the checks failed on "enforce-label"

@dhhagan dhhagan added the enhancement New feature or request label Oct 12, 2023
@lswainemoore lswainemoore merged commit 002b2bc into quant-aq:main Nov 28, 2023
8 of 10 checks passed
@lswainemoore
Copy link
Contributor

Hi @christopherDT -- just merged this PR! Thanks! The readme changes are particularly appreciated. I'm trying to run the tests locally, but don't seem to have the QUANTAQ_PACKAGE_KEY. Do you have that lying around / would you mind emailing me ([email protected] or David a One-Time Secret or something?

@christopherDT
Copy link
Contributor Author

sent you an email with the package key!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants