Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip actions #3315

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Tooltip actions #3315

wants to merge 3 commits into from

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented Jun 13, 2024

This PR adds the contextual dropdown menu to editor tooltips:
Screenshot 2024-06-13 at 14 17 07

TODO before this can be merged:

  • fix the critical problem with the menu disappearing if the pointer is outside of the tooltips box (looking through hoverTooltip source code, it doesn't seem possible to customize, so we'd have to fork hoverTooltip implementation from Codemirror)
    • alternatively, we could replace the dropdown menu with a set of buttons that don't bleed outside of the tooltip box; but we're going to have many actions, eventually, so this won't scale
  • implement more useful actions - one that I particularly care about is "add documentation", which should open a modal window for editing the markdown for @doc tag
  • not a blocker, but it would be nice to have these actions available from the viewer side of the playground too (this would require exposing the entire EditorView object outside of <CodeEditor>, but that shouldn't be difficult)

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Jun 13, 2024 5:26pm
quri-ui ✅ Ready (Inspect) Visit Preview Jun 13, 2024 5:26pm
squiggle-components ✅ Ready (Inspect) Visit Preview Jun 13, 2024 5:26pm
squiggle-website ✅ Ready (Inspect) Visit Preview Jun 13, 2024 5:26pm

Copy link

changeset-bot bot commented Jun 13, 2024

🦋 Changeset detected

Latest commit: 9eb71ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@quri/squiggle-components Patch
@quri/versioned-squiggle-components Patch
vscode-squiggle Patch
@quri/squiggle-lang Patch
@quri/prettier-plugin-squiggle Patch
@quri/squiggle-textmate-grammar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@berekuk berekuk changed the base branch from main to flat-decorators June 13, 2024 17:21
@berekuk
Copy link
Collaborator Author

berekuk commented Jun 13, 2024

Note: this PR is done on top of #3314, can switch to main after that one is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 To prioritize
Development

Successfully merging this pull request may close these issues.

1 participant