Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In step with the "how far can we get with paths starting with
/data
" this PR adds very basicImport
blocks to Shark. Import blocks at the moment are essentially run blocks usinggit
to pull a repository into/data
using a basic Alpine image to do so. For now making them a distinct separate block that is translated into a build script is a little overkill, but I think in the long run it will make it easier for us to support other sources of data and make it nicer for users to simple write:Or something like that rather than manually doing an Obuilder script. For now the format is simple,
(URL, PATH)
pairs with everything being assumed to begit
. There could some role for Vurl here for extra metadata, but I could imagine coming up with am Import DSL for doing more interesting imports of data e.g. importing branches from a git repo and embedding them in the file system.The tests now run a simple
ocaml-test.md
script that uses an import statement and thenopam
anddune
to build things. The invocations ofopam
anddune
use there less common "provide the file path" variants in order to activate the automatic dependency tracking. A small price to pay for what is otherwise a very nice setup I think!