Handle failing commands more gracefully #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes OBuilder to keep failed builds in the ZFS and Rsync backends -- for now they are kept and not distinguished from other builds.
On top of this Shark will now stop processing a markdown file once it encounters a failing command. This includes a single failing command inside a map. I would like to change quite substantially how Shark processes maps and builds in general to support this better but for now this seemed sensible as a first PR. The failed command output is promoted back to the code block and the rest of the markdown file is ignored. On exit we print the failing command and the markdown and return a non-zero exit code.
The CI runs a slightly incorrect markdown file where we expect the
gdal --version
command to fail as there is nogdal
command.