Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle failing commands more gracefully #47

Merged
merged 2 commits into from
May 3, 2024

Conversation

patricoferris
Copy link
Collaborator

This PR adds changes OBuilder to keep failed builds in the ZFS and Rsync backends -- for now they are kept and not distinguished from other builds.

On top of this Shark will now stop processing a markdown file once it encounters a failing command. This includes a single failing command inside a map. I would like to change quite substantially how Shark processes maps and builds in general to support this better but for now this seemed sensible as a first PR. The failed command output is promoted back to the code block and the rest of the markdown file is ignored. On exit we print the failing command and the markdown and return a non-zero exit code.

The CI runs a slightly incorrect markdown file where we expect the gdal --version command to fail as there is no gdal command.

@patricoferris patricoferris merged commit ba7c310 into main May 3, 2024
2 checks passed
@patricoferris patricoferris deleted the pf341-save-failed-builds branch May 3, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant