Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distance variables #49

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Distance variables #49

merged 1 commit into from
Sep 11, 2023

Conversation

patricoferris
Copy link
Contributor

#47 on top of #48

robinmessage
robinmessage approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@robinmessage robinmessage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I just wondered if we could do something like:
export_columns = luc_columns + distance_columns
to make the extraction neater

@patricoferris patricoferris merged commit 9aa1e8c into main Sep 11, 2023
1 check passed
@patricoferris patricoferris deleted the pf341-other-vars branch September 11, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinmessage robinmessage robinmessage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patricoferris @robinmessage