Skip to content

Commit

Permalink
[PBC Resources Estimates 4/4] Add costing functions (#824)
Browse files Browse the repository at this point in the history
* Add k-point THC code.

* Add k-thc notebook.

* Add utilities.

* Add reference data.

* Add missing __init__

* Add missing init / skipifs.

* Fix formatting.

* Resolve review comments.

* Address comments.

* Remove utils.

* No more utils.

* More review comments.

* Fix formatting.

* Formatting + add map to gvec_logic.

* Fix import issues.

* Add utility classes to handler different PBC Hamiltonian factorizations.

Add inits.

* No more utils.

* Tidyup.

* Fix formatting.

* Add functionality to compute PBC lambda values.

* Fix formatting and docstrings.

* Fix whitespace.

* Add costing PBC costing notebooks.

* Add utility costing functions.

* Make costing into package and add notebook.

* Add missing utilities.

* Refactor.

* Fix tests.

* Fix imports and whitespace.

* Fix up some merge issues.

* Mark slow test slow.

* Remove file.

* Add missing skipif.

* Add missing import.

* Address comments.

* Fix formatting.

* Fix lint /import errors.

* Fix import.
  • Loading branch information
fdmalone authored Aug 24, 2023
1 parent 78bba46 commit 7884817
Show file tree
Hide file tree
Showing 28 changed files with 3,220 additions and 8 deletions.
86 changes: 86 additions & 0 deletions src/openfermion/resource_estimates/pbc/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
# Resource Estimation for Periodic Systems

Module `openfermion.resource_estimates.pbc` facilitates fault-tolerant (FT) resource estimates for second-quantized symmetry-adapted Hamiltonians with periodic boundary conditions (PBC).

The module provides symmetry adapted sparse, single, double and tensor hypercontraction representations of the Hamiltonians.

For the methods listed above, there are sub-routines which:
* factorize the two-electron integrals if appropriate
* compute the associated lambda values, `compute_lambda()`
* estimate the number of logical qubits and Toffoli gates required to simulate with this factorization, `compute_cost()`

### Details

Given a pyscf scf calculation of a periodic system with k-points:

```python
from pyscf.pbc import gto, scf

cell = gto.Cell()
cell.atom = '''
C 0.000000000000 0.000000000000 0.000000000000
C 1.685068664391 1.685068664391 1.685068664391
'''
cell.basis = 'gth-szv'
cell.pseudo = 'gth-hf-rev'
cell.a = '''
0.000000000, 3.370137329, 3.370137329
3.370137329, 0.000000000, 3.370137329
3.370137329, 3.370137329, 0.000000000'''
cell.unit = 'B'
cell.verbose = 0
cell.build()

kmesh = [1, 1, 3]
kpts = cell.make_kpts(kmesh)
nkpts = len(kpts)
mf = scf.KRHF(cell, kpts).rs_density_fit()
mf.kernel()
```

then resource estimates for the SF, DF, and THC factorization schemes can be generated a range of cutoffs. For example:

```python
from openfermion.resource_estimates.pbc import sf

costs = sf.generate_costing_table(mf, name='carbon_diamond', naux_cutoffs=[20,25,30,35,40,45,50])
print(costs.to_string(index=False))
```
will generate a `pandas.DataFrame` of resource estimates for the single factorization Hamiltonian (`sf`) and MP2 correlation energies for the range of auxiliary dimension (`naux_cutoffs`).


Note that the automated costing computes the MP2 correlation energy error as a reference point for monitoring the convergence of the factorization with respect to sparsity or the size of auxiliary dimension. MP2 may be a poor model chemistry depending on the system, changing the option `energy_method = "CCSD"` will use CCSD instead, but this may become too expensive as the system size grows.

The philosophy is that all costing methods are captured in the namespace related to the type of factorization. So if one wanted to repeat the costing for DF or THC factorizations, one could do

```python
from openfermion.resource_estimates.pbc import df, thc

# We need to specify eigenvalue threshold for second factorization.
df_cutoffs = [1e-2, 5e-3, 1e-3, 5e-4, 1e-4, 5e-5, 1e-5]
df_table = df.generate_costing_table(
mf,
name='carbon-diamond',
cutoffs=df_cutoffs)

# Specify THC rank parameter we wish to scan over.
# Note THC dimension M = thc_rank_param * N, N = number of spin orbitals in the
# unit cell.
thc_rank_params = [2, 4, 6]
# if you want to save each THC result to a file, you can set 'save_thc' to True
thc_table = thc.generate_costing_table(mf, name='carbon-diamond', thc_rank_params=thc_rank_params)
```

More fine-grained control is given by subroutines that compute the factorization, the lambda values, and the cost estimates.
Further details are provided in a [tutorial](./notebooks/resource_estimates.ipynb). Note the THC factorization is more involved and we refer the reader to [thc-tutorial](../../notebooks/isdf.ipynb) for further details.

Similar to the case of molecular resource estimation, we do not wish to burden all OpenFermion users with these dependencies, and testing with GitHub workflows is disabled. Currently we only check if pyscf is available. If it is then pytest will pick up the pbc module and run the tests. Note the tests can be quite slow due to the cost associated with building the integrals.

## Requirements
Requirements can be found in [resource_estimates.txt](../../../../dev_tools/requirements/deps/resource_estimates.txt)
```
pyscf
jax
jaxlib
ase
```
8 changes: 8 additions & 0 deletions src/openfermion/resource_estimates/pbc/df/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,11 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from openfermion.resource_estimates import HAVE_DEPS_FOR_RESOURCE_ESTIMATES

if HAVE_DEPS_FOR_RESOURCE_ESTIMATES:
from .compute_lambda_df import compute_lambda
from .generate_costing_table_df import generate_costing_table
from .df_integrals import DFABKpointIntegrals
from .compute_df_resources import compute_cost
Loading

0 comments on commit 7884817

Please sign in to comment.