Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use service account name instead of deployment name #953

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

metacosm
Copy link
Member

Fixes #932

Signed-off-by: Chris Laprun [email protected]

@metacosm metacosm self-assigned this Sep 10, 2024

public class ConfiguredServiceAccountNameShouldBeUsedTest {

public static final String APPLICATION_NAME = "configured-service-account-name";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metacosm isn't this conflicting your other draft PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is, I created the other one to show current progress and discuss things with @iocanel. This one will get a workaround with the current code to provide a fix but, ultimately, the proper way to handle things should be what has been started in the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fine-tuning service account namespace
2 participants