Merge pull request #1337 from gtroitsk/bug/websockets

Remove todos from WebSockets modules
quarkus-qe · Aug 1, 2023 · baffa67 · baffa67
2 parents 5cc2206 + 9d88dbc
commit baffa67
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 3 deletions.
diff --git a/websockets/quarkus-websockets/src/main/java/io/quarkus/ts/websockets/producer/Pusher.java b/websockets/quarkus-websockets/src/main/java/io/quarkus/ts/websockets/producer/Pusher.java
@@ -23,7 +23,6 @@ public class Pusher {
     @OnOpen
     public void onOpen(Session session) {
         this.session = session;
-        //todo messages are not sent on opening of session. Need to investigate and create reproducer
     }
 
     @OnMessage

diff --git a/...sockets/src/test/java/io/quarkus/ts/websockets/producer/WebSocketsProducerConsumerIT.java b/...sockets/src/test/java/io/quarkus/ts/websockets/producer/WebSocketsProducerConsumerIT.java
@@ -177,7 +177,6 @@ public void open(Session session) {
 
         @OnMessage
         void message(String msg) {
-            // TODO sometimes sessions are reopened several times without closing, need to check, if this is right
             if (!msg.endsWith("joined")) {
                 messages.add(msg);
             }

diff --git a/websockets/websockets-client/src/main/java/io/quarkus/ts/websockets/client/Pusher.java b/websockets/websockets-client/src/main/java/io/quarkus/ts/websockets/client/Pusher.java
@@ -22,7 +22,6 @@ public class Pusher {
     @OnOpen
     public void onOpen(Session session) {
         this.session = session;
-        //todo messages are not sent on opening of session. Need to investigate and create reproducer
     }
 
     @OnMessage