Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to solve weekly failure, when app can not found the cluster while running on Openshift #1229

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Attempt to solve weekly failure, when app can not found the cluster while running on Openshift #1229

merged 1 commit into from
Jul 20, 2023

Conversation

fedinskiy
Copy link
Contributor

Summary

Attempt to solve weekly failure, when app can not found the cluster while running on Openshift

Fixes fails in testRestartInfinispanCluster method. Occasional failure in logger while closing should be addressed in the FW.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy requested a review from jsmrcka May 16, 2023 15:52
@fedinskiy
Copy link
Contributor Author

run tests

jsmrcka
jsmrcka reviewed May 18, 2023
View reviewed changes
Copy link
Contributor

@jsmrcka jsmrcka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot reproduce the original failure (my localhost -> OCP 4.12).
But interestingly, I can reproduce the failure from OCP runs after applying the patch.

...ent/src/test/java/io/quarkus/ts/infinispan/client/OperatorOpenShiftInfinispanCountersIT.java Outdated Show resolved Hide resolved
@fedinskiy
Copy link
Contributor Author

That is especially interesting, given, that no changes affect OperatorOpenShiftInfinispanObjectsIT. I suggest to try multiple runs of the tests (and I will take a look into the failure)

@jsmrcka
Copy link
Contributor

jsmrcka commented May 23, 2023

run tests

@rsvoboda
Copy link
Member

rsvoboda commented Jun 7, 2023

What about this PR @jsmrcka @fedinskiy

@fedinskiy
Copy link
Contributor Author

run tests

@fedinskiy fedinskiy requested a review from jsmrcka July 20, 2023 11:08
@jsmrcka jsmrcka merged commit 771c9dd into main Jul 20, 2023
@michalvavrik michalvavrik deleted the fix/cluster-not-found branch July 27, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmrcka jsmrcka jsmrcka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedinskiy @jsmrcka @rsvoboda