Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Re-enable tests on IBM platforms due to removal of zookeeper #2030

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

dale-fu
Copy link
Contributor

@dale-fu dale-fu commented Sep 19, 2024

Summary

Due to #1854, we can re-enable the tests that were using the zookeeper image on IBM platforms. The previously skipped tests passing on latest 3.8 release.

Example test runs:

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@dale-fu
Copy link
Contributor Author

dale-fu commented Sep 19, 2024

Will need to backport into main and most likely 3.15 branch afterwards.

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dale-fu please address formatting issues

@michalvavrik
Copy link
Member

let's try again @dale-fu

@dale-fu
Copy link
Contributor Author

dale-fu commented Sep 20, 2024

I'm so confused, all I did was remove DisabledIfSystemProperty(), I don't even think I touched the imports. Looking at the log, it seems like the imports are already alphabetical on OperatorOpenShiftAmqStreamsKafkaStreamIT.java.

@michalvavrik
Copy link
Member

I'm so confused, all I did was remove DisabledIfSystemProperty(), I don't even think I touched the imports. Looking at the log, it seems like the imports are already alphabetical on OperatorOpenShiftAmqStreamsKafkaStreamIT.java.

You have removed DisabledIfSystemPropert, unused imports are not allowed. Please drop it.

@dale-fu
Copy link
Contributor Author

dale-fu commented Sep 20, 2024

I'm an idiot, I was looking at it the wrong way. Clearly nothing to do with alphabetical ordering.

@michalvavrik
Copy link
Member

I'm an idiot, I was looking at it the wrong way. Clearly nothing to do with alphabetical ordering.

No worry, validation exception is not good, but that's simply how it is.

@michalvavrik michalvavrik merged commit ffdb71b into quarkus-qe:3.8 Sep 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants