-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable on Native #2038
Disable on Native #2038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I suspect imports are not sorted, but that's the CI problem. Thanks for the fix.
cecc6f4
to
522d750
Compare
I understand the disable in dev mode, but why for prod mode? Keycloak team is the trigger, but we aim to support this for any customer. And having cli utilities compiled into native can be handy for them - one binary / no need for java runtime / faster boot |
Ok in that case, this needs further investigation, why it failed in our jobs and let's check the guide that already mention some incompatibilities and workaround https://quarkus.io/guides/picocli#native-mode-support |
just to be clear, I don't believe there are any incompatibilities. what the guide says is that "if we missed something with future bumps, here is trick that fixes native mode". but it will be a bug anyway, so if there is something not working, file the issue. |
anyway, I suggest to merge this and give @jcarranzan time to investigate. there is no point in having failing daily builds. |
because it follows current TP, so let's change TP first... |
Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version', 'PR - Windows - JVM build - Latest Version' |
1 similar comment
Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version', 'PR - Windows - JVM build - Latest Version' |
let's continue here #2043 (review) |
Summary
As I described in the TP (https://github.com/quarkus-qe/quarkus-test-plans/blob/9c6b5a01882dd0a96fa0fad9019eeb479760e22e/QUARKUS-4221.md?plain=1#L11) , this is supported only for JVM.
Please select the relevant options.
run tests
phrase in comment)Checklist: