Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve flakiness reporting by storing flaky run report with failed test name and failure message #2045

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Sep 24, 2024

Summary

This is the first step to improve flakiness reporting. I need to have the file that we can inspect. Later I can experiment on commenting etc..

Tested: https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/11019026504?pr=2045

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Copy link

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version', 'PR - Linux - Native build - Latest Version', 'PR - Windows - JVM build - Latest Version'

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalvavrik michalvavrik merged commit f730255 into quarkus-qe:main Sep 24, 2024
9 of 14 checks passed
@michalvavrik michalvavrik deleted the feature/improve-flakiness-reporting branch September 24, 2024 20:12
@michalvavrik
Copy link
Member Author

Ignore next comment, I am just testing formatting for myself.

@michalvavrik
Copy link
Member Author

michalvavrik commented Sep 25, 2024

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version', 'PR - Linux - Native build - Latest Version', 'PR - Windows - JVM build - Latest Version'

Artifact flaky-run-report-whatever-1 contains following failures:

  • Test name: io.quarkus.qe.reporter.flakyrun.FlakyTest.testFlaky
    Date and time: 2024-09-25T18:26:07.744582807+02:00[Europe/Prague]
    Failure message: failing to test flakiness reporting
    Failure stacktrace:
org.opentest4j.AssertionFailedError: failing to test flakiness reporting
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:38)
	at org.junit.jupiter.api.Assertions.fail(Assertions.java:138)
	at io.quarkus.qe.reporter.flakyrun.FlakyTest.testFlaky(FlakyTest.java:18)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

Artifact 'flaky-run-report-whatever-2' contains following failures:
Test name: io.quarkus.qe.reporter.flakyrun.FlakyTest.testFlaky
Date and time: 2024-09-25T18:26:07.744582807+02:00[Europe/Prague]
Failure message: failing to test flakiness reporting
Failure stacktrace:

org.opentest4j.AssertionFailedError: failing to test flakiness reporting
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:38)
	at org.junit.jupiter.api.Assertions.fail(Assertions.java:138)
	at io.quarkus.qe.reporter.flakyrun.FlakyTest.testFlaky(FlakyTest.java:18)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/flaky-test Signal that flaky tests were detected during CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants