-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.15] Backports for 25.9 #2046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fedinskiy I must admit I personally don't care much about it, but there is some directive from @rsvoboda that our team seems to follow that when you cherry-pick things, you keep "cherry picked from commit sha " with git cherry-pick -x sha
. Your commits don't seem to have it. Here is an example if you wonder https://github.com/quarkus-qe/quarkus-test-framework/pull/1325/commits. What shall we do about it?
It kinda depends on how much of a work is it for you, I'd definitely not spend hour on fixing it, so just let me know.
@michalvavrik I was not aware of this directive, is it written down somewhere? It will take roughly ten minutes with my script, so that is not a problem |
* Add test for DLQ metric counting (cherry picked from commit f8e76c8)
"Cache" service is deprecated and removed from the newest versions of Inifinspan[1][2] and it already became a problem for IBM testing folks[3] [1] https://access.redhat.com/solutions/7010384 [2] https://access.redhat.com/solutions/6972352 [3] https://issues.redhat.com/browse/QQE-961 (cherry picked from commit 3103d5e)
…fixed" (quarkus-qe#2007) This reverts commit c4ca78c. (cherry picked from commit 76627f0)
* Disabling DB2 tests on aarch64 profile as DB2 is not supported on aarch64 architecture, so our test service will not work. (cherry picked from commit 892d7c4)
* Disabling MS SQL tests on aarch64 profile as MS SQL is not supported on aarch64 architecture, so our test service will not work. (cherry picked from commit fcb947e)
* Disabling Oracle tests on aarch64 profile as there's no Oracle container available for aarch64 architecture, so our test service will not work. (cherry picked from commit 609c549)
* Disabling syslog tests on aarch64 as the currently used container is not multiarch. (cherry picked from commit a7364b0)
* Disabling Spring Cloud Server tests on aarch64 as there's no aarch64 based container we can use as test service. (cherry picked from commit 4bd94a0)
We do not test Camel ATM, so its pom can be removed It seems, that Quarkus Camel is not compatible with Wiremock, since then QC is added, Wiremock fails to find Jetty 11. This can be solved by using standalone Wiremock in case we want to test Camel some day (cherry picked from commit 01b9131)
Reverts quarkus-qe@2b13fe0 (cherry picked from commit a8b04b7)
- Enable back disabled tests - Update reasons for the test which should be disabled (cherry picked from commit 85e52d5)
I heard that suggestion many times from Rostislav in my PRs or where I reviewed it. After that, reviewers of my backports started to request it. No, I don't think it's written, but IMO it is followed now.
cool, if you don't ind please do it, and maybe share the script because I always do it manually :-) |
(cherry picked from commit dfb7a58)
(cherry picked from commit 5bd7470)
(cherry picked from commit 27f733d)
) (cherry picked from commit 82c02d3)
- Use the one from linuxserver, since it supports ARM. - Also do some refactoring and change of config files (cherry picked from commit 60b56ef)
(cherry picked from commit bbb8497)
) (cherry picked from commit 9ea57d0)
(cherry picked from commit 2935041)
While testing on ARM, our control message (64 symbols) is not shown in logs. I presume, that on ARM this message weight more, than 128 bytes; and so it is filtered by Quarkus. We should be careful around encodings and byte limits in the future. (cherry picked from commit fed2b5d)
f85848f
to
1608401
Compare
Done, will share my script in the chat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run tests |
Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version' |
Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version' |
Natice OCP failure:
I do not think it is related, but will rerun just in case |
Summary
Backports:
Please select the relevant options.
run tests
phrase in comment)Checklist: