Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.15] Backports for 25.9 #2046

Merged
merged 20 commits into from
Sep 25, 2024
Merged

Conversation

fedinskiy
Copy link
Contributor

Summary

Backports:

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedinskiy I must admit I personally don't care much about it, but there is some directive from @rsvoboda that our team seems to follow that when you cherry-pick things, you keep "cherry picked from commit sha " with git cherry-pick -x sha. Your commits don't seem to have it. Here is an example if you wonder https://github.com/quarkus-qe/quarkus-test-framework/pull/1325/commits. What shall we do about it?

It kinda depends on how much of a work is it for you, I'd definitely not spend hour on fixing it, so just let me know.

@fedinskiy
Copy link
Contributor Author

@michalvavrik I was not aware of this directive, is it written down somewhere?

It will take roughly ten minutes with my script, so that is not a problem

mocenas and others added 11 commits September 25, 2024 09:40
* Add test for DLQ metric counting

(cherry picked from commit f8e76c8)
"Cache" service is deprecated and removed from the newest versions of
Inifinspan[1][2] and it already became a problem for IBM testing folks[3]

[1] https://access.redhat.com/solutions/7010384
[2] https://access.redhat.com/solutions/6972352
[3] https://issues.redhat.com/browse/QQE-961

(cherry picked from commit 3103d5e)
* Disabling DB2 tests on aarch64 profile as DB2 is not supported
  on aarch64 architecture, so our test service will not work.

(cherry picked from commit 892d7c4)
* Disabling MS SQL tests on aarch64 profile as MS SQL is not supported
  on aarch64 architecture, so our test service will not work.

(cherry picked from commit fcb947e)
* Disabling Oracle tests on aarch64 profile as there's no Oracle
  container available for aarch64 architecture, so our test service
  will not work.

(cherry picked from commit 609c549)
* Disabling syslog tests on aarch64 as the currently used container is
  not multiarch.

(cherry picked from commit a7364b0)
* Disabling Spring Cloud Server tests on aarch64 as there's no aarch64
  based container we can use as test service.

(cherry picked from commit 4bd94a0)
We do not test Camel ATM, so its pom can be removed
It seems, that Quarkus Camel is not compatible with Wiremock,
since then QC is added, Wiremock fails to find Jetty 11.
This can be solved by using standalone Wiremock in case we want to test
Camel some day

(cherry picked from commit 01b9131)
Reverts quarkus-qe@2b13fe0

(cherry picked from commit a8b04b7)
- Enable back disabled tests
- Update reasons for the test which should be disabled

(cherry picked from commit 85e52d5)
@michalvavrik
Copy link
Member

@michalvavrik I was not aware of this directive, is it written down somewhere?

I heard that suggestion many times from Rostislav in my PRs or where I reviewed it. After that, reviewers of my backports started to request it. No, I don't think it's written, but IMO it is followed now.

It will take roughly ten minutes with my script, so that is not a problem

cool, if you don't ind please do it, and maybe share the script because I always do it manually :-)

jcarranzan and others added 9 commits September 25, 2024 09:42
(cherry picked from commit dfb7a58)
- Use the one from linuxserver, since it supports ARM.
- Also do some refactoring and change of config files

(cherry picked from commit 60b56ef)
While testing on ARM, our control message (64 symbols) is not shown in
logs. I presume, that on ARM this message weight more, than 128 bytes;
and so it is filtered by Quarkus. We should be careful around
encodings and byte limits in the future.

(cherry picked from commit fed2b5d)
@fedinskiy
Copy link
Contributor Author

Done, will share my script in the chat

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedinskiy
Copy link
Contributor Author

run tests

@github-actions github-actions bot added the triage/flaky-test Signal that flaky tests were detected during CI run label Sep 25, 2024
Copy link

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

Copy link

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

@fedinskiy
Copy link
Contributor Author

Natice OCP failure:

10:27:51,849 INFO  oc: 3m27s       Warning   Failed              pod/app-8d4596bd5-jmjvs    Failed to pull image "image-registry.openshift-image-registry.svc:5000/ts-qvmpwvozgi/app@sha256:dd515ef65a5fd75ff52518635826050000b8c1cb7d1285c02a7afb43d408d3a8": reading manifest sha256:dd515ef65a5fd75ff52518635826050000b8c1cb7d1285c02a7afb43d408d3a8 in image-registry.openshift-image-registry.svc:5000/ts-qvmpwvozgi/app: authentication required

I do not think it is related, but will rerun just in case

@michalvavrik michalvavrik merged commit ec02e14 into quarkus-qe:3.15 Sep 25, 2024
10 checks passed
@fedinskiy fedinskiy deleted the backports/25.9 branch September 26, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/flaky-test Signal that flaky tests were detected during CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants