Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compression test failures as media types compressed by defaults has changed #2057

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Sep 27, 2024

Summary

The io.quarkus.ts.http.reactiveroutes.CompressionHandlerIT and io.quarkus.ts.http.jakartarest.reactive.CompressionHandlerIT are failing because defaults has changed https://github.com/quarkusio/quarkus/pull/43497/files. Application/json and XHTML/XML are now compressed by default. This breaking changes is documented https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.16#http-compression.

This PR:

  • moves APP/JSON from uncompressed by default to the types that are compressed by default
  • adds new type that is compressed by default (XHTML/XML)
  • keeps original behavior of test that verifies mixing of compressed and uncompressed types by default, the app/json is replaced by app/xml which is still uncompressed by default

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Copy link
Member

@gtroitsk gtroitsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixes

@gtroitsk gtroitsk merged commit a83e273 into quarkus-qe:main Sep 28, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/fix-compression-tests-failures branch September 28, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants