Apply idea code analysis suggestions Http module #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtroitsk
requested changes
Nov 13, 2024
...-advanced-reactive/src/main/java/io/quarkus/ts/http/advanced/reactive/MediaTypeResource.java
Outdated
Show resolved
Hide resolved
...advanced-reactive/src/test/java/io/quarkus/ts/http/advanced/reactive/DownloadResourceIT.java
Outdated
Show resolved
Hide resolved
| @@ -33,13 +33,11 @@ public Uni<GrpcReflectionResponse> reflectionServiceInfo() { | |||
| .setListServices("").build(); | |||
| Uni<ServerReflectionResponse> serverReflectionResponse = invoke(request); | |||
|
|
|||
| Uni<GrpcReflectionResponse> grpcReflectionResponse = serverReflectionResponse.map(response -> { | |||
| return serverReflectionResponse.map(response -> { | |||
There was a problem hiding this comment.
Personally I most like original version, it is easier to read what method returns. But I haven't a strong opinion on this
There was a problem hiding this comment.
IMHO this method is short and what is returned is easily readable in method declaration. IMHO that is sufficient. But I also have no strong opinion.
mocenas
force-pushed
the
codestyle_changes_http
branch
from
321a854
to
a090af8
Compare
mocenas
commented
Nov 14, 2024
| @@ -33,13 +33,11 @@ public Uni<GrpcReflectionResponse> reflectionServiceInfo() { | |||
| .setListServices("").build(); | |||
| Uni<ServerReflectionResponse> serverReflectionResponse = invoke(request); | |||
|
|
|||
| Uni<GrpcReflectionResponse> grpcReflectionResponse = serverReflectionResponse.map(response -> { | |||
| return serverReflectionResponse.map(response -> { | |||
There was a problem hiding this comment.
IMHO this method is short and what is returned is easily readable in method declaration. IMHO that is sufficient. But I also have no strong opinion.
...-advanced-reactive/src/main/java/io/quarkus/ts/http/advanced/reactive/MediaTypeResource.java
Outdated
Show resolved
Hide resolved
...advanced-reactive/src/test/java/io/quarkus/ts/http/advanced/reactive/DownloadResourceIT.java
Outdated
Show resolved
Hide resolved
gtroitsk
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Apply code changes from idea to Http module. Mostly fixes unnecessary imports, conversions, throws clause, classes in wrong files etc.
There are also several instances of deprecated APIs, but since that will require more complex changes I want to put that into separate PR.
Please select the relevant options.
run testsphrase in comment)Checklist: