-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage for "method not registered" error in native mode #2254
Add coverage for "method not registered" error in native mode #2254
Conversation
This will work: |
Following jobs contain at least one flaky test:
Run summary: https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/12398471365?pr=2254 Flaky tests:
Failure stacktrace
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will review tomorrow, any reason for @QuarkusIntegrationTest
? I checked code and didn't see anything that would bind this bug issue to upstream test framework.
...p-minimum-reactive/src/test/java/io/quarkus/ts/http/minimum/reactive/OperatorResourceIT.java
Outdated
Show resolved
Hide resolved
...nimum-reactive/src/main/java/io/quarkus/ts/http/minimum/reactive/JakartaRestInterceptor.java
Show resolved
Hide resolved
...p-minimum-reactive/src/test/java/io/quarkus/ts/http/minimum/reactive/OperatorResourceIT.java
Outdated
Show resolved
Hide resolved
...ttp-minimum-reactive/src/main/java/io/quarkus/ts/http/minimum/reactive/OperatorResource.java
Outdated
Show resolved
Hide resolved
...p-minimum-reactive/src/test/java/io/quarkus/ts/http/minimum/reactive/OperatorResourceIT.java
Outdated
Show resolved
Hide resolved
7026230
to
4b73d55
Compare
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Good to merge. One thing I realized is that I'd expect to have this new test method linked to the upstream issue. What are your thoughts on that @fedinskiy ? |
...inimum-reactive/src/test/java/io/quarkus/ts/http/minimum/reactive/HttpMinimumReactiveIT.java
Outdated
Show resolved
Hide resolved
@michalvavrik all related links are in commit description. Would you prefer to have something like Also, is our Jenkins off already? It seems the CI didn't start |
yes please
no idea, it worked yesterday when I was testing FW, I can check later today; anyway, I do not require OCP runs. |
4b73d55
to
deef1b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again.
Described here:
quarkusio/quarkus#44564
quarkusio/quarkus#44613
https://issues.redhat.com/browse/QQE-1234
Summary
(Summarize the problem solved by this PR, and how to verify it manually)
Please select the relevant options.
run tests
phrase in comment)Checklist: