Prevent websocket upgrade from replying with content-length: 0
#139
Conversation
| ChannelHandlerContext context = connection.channelHandlerContext(); | ||
| context.pipeline().remove("httpDecoder"); | ||
| context.pipeline().remove("httpEncoder"); | ||
| request.toWebSocket().onSuccess( ws -> { |
|
Would be great to have a test case. |
This comment has been minimized.
This comment has been minimized.
|
test case is in quarkus integration tests. please note that there currently aren't any tests for the vertx code and junit 4, yuck. I'd be happy to create an incremental unit test, but bootstrapping all the vertx cases is a heavy lift. |
|
Ah yes... I forgot that this project still use junit 4. |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
|
@chonton I will revert this PR, unfortunately. |
|
@chonton @cescoffier |
|
Did you try with WebSocket Next? |
|
(We reverted the fix as it introduced a regression) |
|
@cescoffier |
|
Yes, it is not quite mature. It is going to become our recommended approach
for WebSockets.
Le jeu. 9 janv. 2025 à 11:31, michaelfrid ***@***.***> a
écrit :
… @cescoffier <https://github.com/cescoffier>
I see it's marked as experimental feature. Is it stable enough to be used
in the production environment ?
It also means we need to rewrite our current implementation, right ?
Thank you
—
Reply to this email directly, view it on GitHub
<#139 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADCG7NGNVXFER53I3MJIOT2JZFYDAVCNFSM6AAAAABU3ULHWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZZG42TEMZYHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@cescoffier |
|
Sorry, it is quite mature :-) I don't believe this issue will be fixed anytime soon. At least I do not have the bandwidth. |
Fixes quarkusio/quarkus #370505
Additionally, using the native vertx implementation increases the number of websocket clients and versions supported.