Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache PDFBOX Quickstart #1154

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Conversation

Karm
Copy link
Member

@Karm Karm commented Aug 11, 2022

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

@galderz
Copy link
Member

galderz commented Aug 16, 2022

@gsmet @geoand My gut feeling is that there should be an apache pdfbox extension in Quarkus (or some other Quarkus location) that takes care of the extra configuration that is required for this to work. Thoughts?

@geoand
Copy link
Collaborator

geoand commented Aug 16, 2022

I think that's a great candidate for the Quarkiverse (cc @gastaldi )

# ████████████░▄▄▀█░▄▄█░███░█░▄▄▀█░▄▄▀█░▄▄█████████████
# ████████████░▄▄▀█░▄▄█▄▀░▀▄█░▀▀░█░▀▀▄█░▄▄█████████████
# ████████████░▀▀░█▄▄▄██▄█▄██▄██▄█▄█▄▄█▄▄▄█████████████
# ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
Copy link
Contributor

@gastaldi gastaldi Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a moment this banner reminded me when I used to access BBS to download sharewares. Cool 😃

@gastaldi
Copy link
Contributor

I think that's a great candidate for the Quarkiverse (cc @gastaldi )

That is an excellent idea, any candidates to lead it?

@geoand
Copy link
Collaborator

geoand commented Aug 16, 2022

I would say @Karm signed up by creating this PR 😊

@Karm
Copy link
Member Author

Karm commented Aug 16, 2022

I get the vibe. It seems like a new extension would be warranted. I think it might have ended up that way anyway, because when you open the can of worms that is PDF and start dealing with signatures, forms, embedded stuff in it etc. there might be substitutions required.

/me reading https://github.com/quarkiverse/quarkiverse/wiki#getting-an-extension-onboarded

@galderz
Copy link
Member

galderz commented Aug 18, 2022

I think this PR could still be integrated while the extension is developed. Doing so would already help users out there wanting to use this. Then once the extension is in place, the quickstart can be revisited to simplify it.

@Karm Once you create an extension with the maven plugin, the best thing to do is to look at the myriad of extensions in quarkus/quarkus and see how they do things. E.g. you could start by getting the extension to register some types for runtime init, then remove that config from the quickstart and see if it all works. Then you slowly add more things to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants