Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix join message in websocket quickstart #1309

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Jul 27, 2023

There should be a "joined" message on user joining, but no message is acctually sent.

No "ready" message is generated on user joining,
so move this message to user incoming.

Relates to quarkusio/quarkus#35061

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

There should be a "joined" message on user joining,
but no message is acctually sent.

No "ready" message is generated on user joining,
so move this message to user incoming.
@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Jul 28, 2023

@mocenas actually, it looks like your assumptions were incorrect? Could you get to the bottom of it?

@gsmet
Copy link
Member

gsmet commented Jul 28, 2023

@gsmet
Copy link
Member

gsmet commented Jul 28, 2023

I see we have another fix proposal here: https://github.com/quarkusio/quarkus-quickstarts/pull/1305/files

@gsmet gsmet mentioned this pull request Jul 28, 2023
10 tasks
@mocenas
Copy link
Contributor Author

mocenas commented Aug 7, 2023

@gsmet Code changes were probably OK, only that tests relied on the old behaviour (it actually seems that entire "ready" message was there just for test purposes).
I changed the tests to work with new behaviour.

@mocenas
Copy link
Contributor Author

mocenas commented Aug 7, 2023

Comparing this PR to #1305 this one is more complex, but gets rid of the "ready" message entirely. Which also means that the ready message will not pop up in the chat.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 7, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants