-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix join message in websocket quickstart #1309
base: development
Are you sure you want to change the base?
Conversation
There should be a "joined" message on user joining, but no message is acctually sent. No "ready" message is generated on user joining, so move this message to user incoming.
This comment has been minimized.
This comment has been minimized.
@mocenas actually, it looks like your assumptions were incorrect? Could you get to the bottom of it? |
I think this is related to the test here: https://github.com/quarkusio/quarkus-quickstarts/blob/main/websockets-quickstart/src/test/java/org/acme/websockets/ChatTest.java#L45 |
I see we have another fix proposal here: https://github.com/quarkusio/quarkus-quickstarts/pull/1305/files |
@gsmet Code changes were probably OK, only that tests relied on the old behaviour (it actually seems that entire "ready" message was there just for test purposes). |
Comparing this PR to #1305 this one is more complex, but gets rid of the "ready" message entirely. Which also means that the ready message will not pop up in the chat. |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
There should be a "joined" message on user joining, but no message is acctually sent.
No "ready" message is generated on user joining,
so move this message to user incoming.
Relates to quarkusio/quarkus#35061
Check list:
Your pull request:
development
branch999-SNAPSHOT
version of Quarkusmvn clean test
)mvn clean package -Pnative
)mvn clean verify -Pnative
)README.md
file (with build and run instructions)pom.xml
andREADME.md