-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reference to nonexistent v1 dev UI from quickstart #1457
Conversation
46735c1
to
b31d2ad
Compare
While I was looking at the index html, I noticed it's out of date in a few other ways (references to reactive, etc) so I've tidied those up as well.
b31d2ad
to
76fbbe0
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is using a later version of Quarkus, you can just remove the index file, as it's dynamic now
Status for workflow
|
I realised we do it dynamically after I'd made the changes, but didn't think about the implications for this quickstart. I guess in the development branch it definitely will be a later version of Quarkus, and the less code we have the better, so good idea, I'll remove it. Thanks. |
Actually, should we remove the index.htmls for all quickstarts in this repository? |
Yes I think we can remove it from all quickstarts (if they use the latest Quarkus) |
Closing in favour of #1459. |
While I was looking at the index html, I noticed it's out of date in a few other ways (references to reactive, etc) so I've tidied those up as well.