Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus.kubernetes.namespace should not be applied to clustered resources #43464

Closed
metacosm opened this issue Sep 24, 2024 · 4 comments · Fixed by #43579
Closed

quarkus.kubernetes.namespace should not be applied to clustered resources #43464

metacosm opened this issue Sep 24, 2024 · 4 comments · Fixed by #43579
Labels
area/kubernetes kind/bug Something isn't working
Milestone

Comments

@metacosm
Copy link
Contributor

Describe the bug

If you use the quarkus.kubernetes.namespace property, it will get applied indiscriminately to all generated Kubernetes resources regardless of whether they actually can accept a namespace or not. While this usually doesn't cause issues with kubectl apply, other processes might be more regarding with respect to structure validation.

Expected behavior

Clustered resources should not have a namespace.

Actual behavior

All generated resources, including clustered ones, have their namespace field set.

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@metacosm metacosm added the kind/bug Something isn't working label Sep 24, 2024
Copy link

quarkus-bot bot commented Sep 24, 2024

/cc @geoand (kubernetes), @iocanel (kubernetes)

@metacosm
Copy link
Contributor Author

See for example: quarkiverse/quarkus-operator-sdk#964

@mcruzdev
Copy link
Contributor

Hi @iocanel, I made a first research here and I think we need to solve it on dekorate side, am I right?

@mcruzdev
Copy link
Contributor

mcruzdev commented Sep 29, 2024

Hi @metacosm @iocanel, I was wrong... It can be solved by kubernetes extension.

I created a pull request to solve it.

@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants