Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decorator to remove namespace from ClusterRole and ClusterRoleBin… #43579

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Sep 29, 2024

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 29, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)

This message is automatically generated by a bot.

@metacosm
Copy link
Contributor

While this solution probably works, I would rather we don't add the namespace to clustered resources in the first place instead of adding it and then removing it.

@mcruzdev
Copy link
Contributor Author

mcruzdev commented Sep 29, 2024

I think adding the AddClusterRole... after AddNamespaceDecorator, works well.

Thank you for this comment @metacosm, I solved it with before method!

@metacosm
Copy link
Contributor

Sorry to be a pain but I think the AddNamespaceDecorator should actually be rewritten completely to deal with this instead of trying to order things in such a way that things work. Maybe the decorator should only target resources that implement Namespaced so that we know for sure that processed resources need a namespace?

@mcruzdev
Copy link
Contributor Author

No worry, I was trying to solve it without big changes, but I agree with you, to deal with order is a problem. I will try to solve in a better way, thank you for the help @metacosm!

@geoand geoand requested a review from iocanel September 30, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus.kubernetes.namespace should not be applied to clustered resources
2 participants