-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix content issues in security guides #41712
Conversation
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
docs/src/main/asciidoc/security-oidc-bearer-token-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
5972113
to
8278214
Compare
This comment has been minimized.
This comment has been minimized.
@rolfedh LGTM too, thanks, should be ready to go once the build issue is fixed; also makes sense to refer to the 25.0.0 as the minimum KC version as noticed by Michal. |
This comment has been minimized.
This comment has been minimized.
56ed539
to
a53c87a
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @rolfedh and @michalvavrik. I'd like to CC @maxandersen and @gsmet just in case before merging it, for them be aware of the proposed convention to use document name specific prefixes/qualifiers for the document local sections, in order to avoid conflicts in a large single RHBQ doc
Hi @sberyozkin. Thanks for suggesting this. |
a53c87a
to
999e386
Compare
This comment has been minimized.
This comment has been minimized.
2a21bec
to
abd49d0
Compare
Status for workflow
|
The change I wanted dropped has been dropped.
🙈 The PR is closed and the preview is expired. |
Prequalified the synchronization job by using the "Try ingesting from an upstream pull request" pipeline schedule to create https://gitlab.cee.redhat.com/quarkus-documentation/quarkus/-/jobs/23659885 . |
This PR incorporates QE feedback from the review of the product security guides into the community files. The changes include: