Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection port for MongoDB dev services using shared network #42472

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 11, 2024

The hostname was fixed in #42065 but when using a shared network and a container build, the application will connect directly to the container port so we shouldn't use the exposed port but the original one.

Fixes #42453

The hostname was fixed in quarkusio#42065 but when using a shared network and a
container build, the application will connect directly to the container
port so we shouldn't use the exposed port but the original one.

Fixes quarkusio#42453
@gsmet
Copy link
Member Author

gsmet commented Aug 11, 2024

@cristianonicolai could you check this one? It's closely related to what you did in #42065 and I would like to make sure I didn't break your use case by fixing another one.

Thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 11, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e853d39.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@cristianonicolai
Copy link
Contributor

@gsmet it looks ok to me

@gsmet gsmet merged commit ccc3b84 into quarkusio:main Aug 12, 2024
22 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 12, 2024
@gsmet
Copy link
Member Author

gsmet commented Aug 12, 2024

Note that I think this all is failing when you reuse the containers. We will need more work to get this properly working.

@gsmet gsmet modified the milestones: 3.14.0.CR1, 3.13.3 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration test fails to start mongo with Liquibase
3 participants