Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @PermissionsAllowed defined on meta-annotation #43241

Conversation

michalvavrik
Copy link
Member

Copy link

github-actions bot commented Sep 12, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/permissions-allowed-meta-annotation branch from 02be060 to 837cd30 Compare September 12, 2024 17:01
Copy link

quarkus-bot bot commented Sep 12, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 837cd30.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@michalvavrik
Copy link
Member Author

michalvavrik commented Sep 12, 2024

FYI @sberyozkin there is some WebAuthn failure that is not related:

2024-09-12T18:29:00.3799005Z Caused by: java.lang.RuntimeException: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=docker.io/postgres:14, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@202902d5)
2024-09-12T18:29:00.3802884Z 	at io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor.startDevDb(DevServicesDatasourceProcessor.java:367)
2024-09-12T18:29:00.3805407Z 	at io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor.launchDatabases(DevServicesDatasourceProcessor.java:121)
2024-09-12T18:29:00.3807386Z 	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
2024-09-12T18:29:00.3808752Z 	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
2024-09-12T18:29:00.3809867Z 	at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
2024-09-12T18:29:00.3810901Z 	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
2024-09-12T18:29:00.3812163Z 	at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2516)
2024-09-12T18:29:00.3813567Z 	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2495)
2024-09-12T18:29:00.3814945Z 	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1521)
2024-09-12T18:29:00.3816056Z 	at java.base/java.lang.Thread.run(Thread.java:840)
2024-09-12T18:29:00.3816886Z 	at org.jboss.threads.JBossThread.run(JBossThread.java:483)

Let me know if you require rebase on current main to retrigger whole CI. (well, we will see how other in progress runs go) You could also re-trigger just this particular run in the checks tab. It would be easier.

This comment has been minimized.

@michalvavrik
Copy link
Member Author

hey @geoand , I remember you triggered just one failed run in CI in one of my PRs. Could you please retrigger just integration-tests/security-webauthn? It failed over pulling of Docker image. Don't want to run whole CI as it takes long in this PR.

@geoand
Copy link
Contributor

geoand commented Sep 13, 2024

Done!

@michalvavrik
Copy link
Member Author

Done!

Thanks!

Copy link

quarkus-bot bot commented Sep 13, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 837cd30.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 778f94b into quarkusio:main Sep 13, 2024
56 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 13, 2024
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 13, 2024
@michalvavrik michalvavrik deleted the feature/permissions-allowed-meta-annotation branch September 13, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security - Ability to create custom permission annotation
3 participants