Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC: Encapsulate static/dynamic tenants maps in TenantConfigBean #43590

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

snazy
Copy link
Contributor

@snazy snazy commented Sep 30, 2024

Lets TenantConfigBean be the sole "owner" of the static/dynamic tenants maps, adds/changes accessor methods for tenants. Also introduces a functional interface to create tenants.

No functional change, only moving code around.

Lets `TenantConfigBean` be the sole "owner" of the static/dynamic tenants maps, adds/changes accessor methods for tenants. Also introduces a functional interface to create tenants.

No functional change, only moving code around.
Copy link

github-actions bot commented Sep 30, 2024

🎊 PR Preview 1603d2c has been successfully built and deployed to https://quarkus-pr-main-43590-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @snazy, I believe the iterations are going nicely now with yourself and @michalvavrik helping out, I can see now the light in the end of the tunnel :-), please wrap the dynamic map further once this PR is merged, proposal is do it similarly to for example the BackChannelLogoutCache. And then, later still, we can look at supporting the cache pluggability to support caffeine, etc, as you originally proposed

@michalvavrik Have a quick look please, I think this PR is good to go now, the orElseThrow() in the create dynamic context does not harm, it is preceeded by an OIDC exception throw if the tenant id is null

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 30, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit ac50eb6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 30, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ac50eb6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sberyozkin sberyozkin merged commit 351b9f9 into quarkusio:main Sep 30, 2024
25 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 30, 2024
@snazy snazy deleted the oidc-encapsulate-tenants-maps branch September 30, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants