Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Maximum Message Size for Vert.x gRPC Server #43596

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

cescoffier
Copy link
Member

Previously, the Vert.x gRPC server was created without passing any configuration. This commit creates an instance of GrpcServerOptions to configure the maximum message size for the server. At the moment, there is no other configuration, but it will be extended with Vert.x 5.

To maintain consistency, we reuse the maxInboundMessageSize property instead of introducing a dedicated one.

Fixes #43573

Previously, the Vert.x gRPC server was created without passing any configuration. This commit creates an instance of `GrpcServerOptions` to configure the maximum message size for the server. At the moment, there is no other configuration, but it will be extended with Vert.x 5.

To maintain consistency, we reuse the maxInboundMessageSize property instead of introducing a dedicated one.

Fixes quarkusio#43573
@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Sep 30, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 30, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 93e6eac.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

🎊 PR Preview 1603d2c has been successfully built and deployed to https://quarkus-pr-main-43596-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 30, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 93e6eac.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@cescoffier cescoffier merged commit 4cab5df into quarkusio:main Sep 30, 2024
38 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC RESOURCE_EXHAUSTED with quarkus.grpc.server.use-separate-server=false
2 participants