Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute: fix generated ValueResolvers #43602

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Sep 30, 2024

@mkouba mkouba requested a review from ia3andy September 30, 2024 15:40
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Sep 30, 2024
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This comment has been minimized.

- fixes quarkusio#43489
- consider default methods in class hierarchy; previously, interface default methods were only considered if a
ValueResolver was generated for an interface
- also consider inherited fields in a class hierarchy
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 30, 2024
Copy link

quarkus-bot bot commented Sep 30, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit bc206a1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit 282d218 into quarkusio:main Oct 1, 2024
23 checks passed
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 1, 2024
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Oct 1, 2024
mkouba added a commit to mkouba/quarkus that referenced this pull request Oct 2, 2024
@gsmet gsmet modified the milestones: 3.16.0.CR1, 3.15.2 Nov 13, 2024
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Nov 13, 2024
bschuhmann pushed a commit to bschuhmann/quarkus that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qute The template engine kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qute Generated ValueResolver for interface default methods
3 participants