-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qute: fix generated ValueResolvers #43602
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Sep 30, 2024
- fixes Qute Generated ValueResolver for interface default methods #43489
- consider default methods in class hierarchy; previously, interface default methods were only considered if a ValueResolver was generated for an interface
- also consider inherited fields in a class hierarchy
ia3andy
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment has been minimized.
This comment has been minimized.
- fixes quarkusio#43489 - consider default methods in class hierarchy; previously, interface default methods were only considered if a ValueResolver was generated for an interface - also consider inherited fields in a class hierarchy
mkouba
added
the
triage/waiting-for-ci
Ready to merge when CI successfully finishes
label
Sep 30, 2024
Status for workflow
|
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
Ready to merge when CI successfully finishes
labels
Oct 1, 2024
mkouba
added a commit
to mkouba/quarkus
that referenced
this pull request
Oct 2, 2024
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this pull request
Nov 13, 2024
- follows up on quarkusio#43602 (cherry picked from commit fdd1ae4)
bschuhmann
pushed a commit
to bschuhmann/quarkus
that referenced
this pull request
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.