Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Doc - Rewrite xrefs for all config guide #43943

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Oct 17, 2024

Note that it also contains some other changes coming from #42677 to reduce further merging hell.

Supersedes #43808 .

@yrodiere please have a look at what's generated as your changes reshuffled the doc and it's a bit hard to make sure this works properly. From what I could see, it seemed OK and the build is fine with the two commits from your PR - but better check things are fine for you.

In the light of the Spring config metadata, let's get rid of sourceClass
and let's avoid using sourceType for the field/method type as it's
confusing.

Fixes quarkusio#43175
When we attach the config metadata, we need to consider only the
properties of the current extension and not those from potential
internal/common extensions: these will be published for the
internal/common extensions themselves.
The all config guide might reference links from the current guide and we
need to make sure they still work.
@gsmet gsmet requested a review from yrodiere October 17, 2024 17:36
@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Oct 17, 2024
Copy link

🎊 PR Preview 5c3944b has been successfully built and deployed to https://quarkus-pr-main-43943-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link

quarkus-bot bot commented Oct 17, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 421ea82.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Oct 17, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 421ea82.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/kotlin

io.quarkus.kotlin.maven.it.KotlinRemoteDevModeIT.testThatTheApplicationIsReloadedOnKotlinChange - History

  • org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes. - java.lang.RuntimeException
java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:86)
	at io.quarkus.kotlin.maven.it.KotlinRemoteDevModeIT.testThatTheApplicationIsReloadedOnKotlinChange(KotlinRemoteDevModeIT.java:23)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally by rebasing #39416 on this PR, and it works great!

Thanks a lot @gsmet .

@gsmet gsmet merged commit 35294cd into quarkusio:main Oct 18, 2024
54 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants