-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config Doc - Rewrite xrefs for all config guide #43943
Conversation
In the light of the Spring config metadata, let's get rid of sourceClass and let's avoid using sourceType for the field/method type as it's confusing. Fixes quarkusio#43175
When we attach the config metadata, we need to consider only the properties of the current extension and not those from potential internal/common extensions: these will be published for the internal/common extensions themselves.
The all config guide might reference links from the current guide and we need to make sure they still work.
🎊 PR Preview 5c3944b has been successfully built and deployed to https://quarkus-pr-main-43943-preview.surge.sh/version/main/guides/
|
Status for workflow
|
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that it also contains some other changes coming from #42677 to reduce further merging hell.
Supersedes #43808 .
@yrodiere please have a look at what's generated as your changes reshuffled the doc and it's a bit hard to make sure this works properly. From what I could see, it seemed OK and the build is fine with the two commits from your PR - but better check things are fine for you.