Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working Groups style updates #2080

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

insectengine
Copy link
Collaborator

Fixes #2046

cescoffier and others added 2 commits August 11, 2024 15:34
- Provide the script that generate the wg.yaml
- Create a workflow that update the working group yaml periodically
- Add the wg page and layout
- A bit of CSS to make the page looks ok
Copy link

github-actions bot commented Aug 14, 2024

🙈 The PR is closed and the preview is expired.

@gsmet
Copy link
Member

gsmet commented Aug 14, 2024

@cescoffier let's iterate it (and don't overwrite @insectengine 's changes!)

Summary of my comments in the other PR:

  • we need a dark theme for the cards (and probably more love from @insectengine)
  • you're talking about contacting a point of contact but there's none
  • not completely sure about having wg as the url. I would have gone with working-groups for better SEO. You will have a link or a bookmark.
  • we need to include it in the nav somewhere (probably something to discuss with @insectengine )

In any case, nothing blocking, I let you address what you think makes sense and merge.

@insectengine
Copy link
Collaborator Author

I also took the liberty to change the URL to "/working-groups" as this is consistent with our other URLs

@cescoffier cescoffier merged commit 3069fa5 into quarkusio:main Aug 20, 2024
1 check passed
@insectengine insectengine deleted the workinggroup_styleupdates branch August 20, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants