Updating smoltcp to prevent DoS during network floods #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordens
reviewed
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #337 by updating the
smoltcpdependency to use a branch where the maximum MAC frame processing loop ofsmoltcpis limited by the sockets in use (in our case, 1 frame perpoll()call).It also updates logging to get rid of an extra dependency.
I programmed
stabilizerto stream to multicast244.192.168.1:9293and verified that stream data could be acquired using thestabilizer-streamingpdsbinary. I then programmedboosterwithmainfirmware and verified that the device continually reset due to watchdog timeouts. I then tried this new firmware and confirmed that no further watchdogs were encountered.