Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font awesome instructions when using Kits #16099

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

gregveres
Copy link
Contributor

@gregveres gregveres commented Jul 20, 2023

I have added information on using Font Awesome Pro Kits. In my opinion, this is the way to go when using Font Awesome Pro since it allows you to define a collection of icons that only include icons you use in your project.

I also included a couple of other tips I wish were written down when I was learning how to use Font Awesome in Quasar.

If this information was in this doc, it would have saved me at least 3/4 of a day figuring it all out for myself and pestering people on discord.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

I have added information on using Font Awesome Pro Kits. In my opinion, this is the way to go when using Font Awesome Pro since it allows you to define a collection of icons that only include icons you use in your project. 

I also included a couple of other tips I wish were written down when I was learning how to use Font Awesome in Quasar. 

If this information was in this doc, it would have saved me at least  3/4 of a day figuring it all out for myself and pestering people on discord.
Copy link
Member

@rstoenescu rstoenescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thank you for contributing!
I think it would be better if the two ways are separated. Some of the steps are not required when using Kits, so it'll only confuse someone reading the guide.

Can you please make a separate guide for the Kits?

@gregveres
Copy link
Contributor Author

Should it be a different page, or a different guide on the same page (say below the existing Font Awesome Pro section)?

As requested, I have split the kit instructions out as a seperate section to avoid any confusion and make the instructions more clearer.
@gregveres
Copy link
Contributor Author

@rstoenescu I have updated the document file to split out the Kit instructions. There is now a section for non-kit installation and a section for kit installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants