Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): QLayout containerized on iOS, only force fixed when reveal #16263

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Evertvdw
Copy link
Contributor

Adds a check to QFooter and QHeader that only forces a fixed footer/header when reveal is true.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

Adds a check to QFooter and QHeader that only forces a fixed footer/header when reveal is true.
@github-actions
Copy link

UI Tests Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
2 files    0
2 errors

For more details on these parsing errors, see this check.

Results for commit 0d9cf44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants