ncm-network: nmstate - add additional route rule parameters

[aka7]

provide additional route rule parameters for nmstate config as defined in https://nmstate.io/devel/yaml_api.html#routes

• Why the change is necessary.
  allow creation of route rules with all options.
• What backwards incompatibility it may introduce.
  none.

[aka7]

@jrha created this for discussion on if there will a way to create sperate schemas for nmstate only options. something to think about. as discussed before.

this isnt urgent but at some point we may need to create unreachable routes and only way to do this with nmstate is through route-rules.

[jrha]

I'll try and do some testing to establish a way of making the schema modular, but otherwise having these options as a separate nmstate sub-dict would seem cleanest.

[jrha]

@aka7 I've had a look at how to deal with the schema and it's probably easiest for me to open a PR against your branch.

[stdweird]

@jrha @aka7 let me know about the PR. but should be something like

in the profile:

• set QUATTOR_TYPES_NETWORK_BACKEND to nmstate
• set QUATTOR_TYPES_NETWORK_LEGACY to false

you should be able to do this for at least all el9 hosts.
best to compile and diff the profiles with and without these set. it should be identical

once you did this, you can start to customise the backend schemas:
typically you add the same type to both backends, but eg on initiscripts https://github.com/quattor/configuration-modules-core/blob/master/ncm-network/src/main/pan/components/network/types/network/backend/initscripts.pan you leave it empty

type network_very_special {}

and in the nmstate backend https://github.com/quattor/configuration-modules-core/blob/master/ncm-network/src/main/pan/components/network/types/network/backend/nmstate.pan you define what you want

type network_very_special {
   woohoo: boolean

these special backend templates are included very early in https://github.com/quattor/configuration-modules-core/blob/master/ncm-network/src/main/pan/components/network/types/network.pan (this is used insetad of the core-legacy schema if you set the previous variables).

then eg in the "shared" route schema https://github.com/quattor/configuration-modules-core/blob/master/ncm-network/src/main/pan/components/network/types/network/route.pan you add it like

type network_route = {
    include network_very_special

and now the nmstate profiles will have support for the woohoo attribute

make sure you have a very unique type name for the type you want to include. the should not have the backend in it (even if it is only implemented for a single backend).

(anyway, untested ;)

[jrha]

Schema migration in #1720.

[jrha]

Rebased and updated to use new schema.

[aka7]

thank you so much @jrha , LGTM

[jrha]

@aka7 I've locked down the types as per my previous comments, if it all makes sense then I'm happy to try and also get this into 24.10.

[aka7]

@aka7 I've locked down the types as per my previous comments, if it all makes sense then I'm happy to try and also get this into 24.10.

@jrha yes please that make sense.