Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncm-sysctl: Cleanup & fixes #1710

Merged
merged 3 commits into from
Sep 17, 2024
Merged

ncm-sysctl: Cleanup & fixes #1710

merged 3 commits into from
Sep 17, 2024
+1 −6

Conversation

jrha
Copy link
Member

@jrha jrha commented Sep 10, 2024 •
edited
Loading

  • Trim newlines at EOF
  • Remove shebang and editor config from tests
  • Deprecate compat-v1 as having no effect
    (The code was removed pre-2008)

@ned21 ned21 added this to the 24.10 milestone Sep 12, 2024
ned21
ned21 previously approved these changes Sep 12, 2024
View reviewed changes
@jrha jrha changed the title ncm-sysctl: Various fixes ncm-sysctl: Cleanup & fixes Sep 17, 2024
@jrha
Copy link
Member Author

jrha commented Sep 17, 2024

I've removed the CAF::Object change and parked it in another branch for now as I realised I couldn't remember why I'd decided to remove it. Apologies for the noise.

@jrha jrha merged commit ecf8f9c into quattor:master Sep 17, 2024
2 checks passed
@jrha jrha deleted the sysctl branch September 17, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned21 ned21 ned21 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
24.10
Development

Successfully merging this pull request may close these issues.
2 participants
@jrha @ned21