Add QuIC Repolinter check #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: quic-nwtn <[email protected]>
|
@quic-nwtn , this checks from the Repolinter are already checked by our existing PR checks. Do we really need this additional linter file? |
|
@mynameistechno , please help here. |
This runs as pre commit hooks? |
|
Yes. Currently we are not set up to merge public commits. When public PRs are submitted, they are merged elsewhere with the appropriate PR checks and included in the following release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This GitHub Action runs Repoliner on push or pull requests to master. This should've been enabled when the project was first setup. We need to enable this and correct violations (ignore the Warnings and focus on the Errors). In some cases, the repolinter rules need to be tweaked depending on the project, which we can discuss.