feat(vscode): make quick-lint a jerk 🖕 #1190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegerot
commented
Jan 19, 2024
plugin/vscode/test/vscode-tests.js
Outdated
| }, | ||
| ] | ||
| ); | ||
| }, |
There was a problem hiding this comment.
I should probably add enable_snarky_config_file and disable_snarky_config_file tests
There was a problem hiding this comment.
I think you can add quick-lint-js.config stuff into the other three tests.
Alternatively, you could data-drive the tests (see line 24 for an existing example):
for (let testCase of [
{
fileName: 'hello.js',
content: 'undeclaredVariable',
englishMessage: 'use of undeclared variable: undeclaredVariable',
snarkyEnglishMessage: 'did you fail spelling class?',
},
{
fileName: 'quick-lint-js.config',
content: '{',
englishMessage: '...',
snarkyEnglishMessage: 'yeah, JSON sucks; try quick-lint-json',
},
]) {
tests = {
...tests,
[`enabling snarky re-lints (${testCase.fileName})`]: async ({ addCleanup }) => {
...
},
};
}There was a problem hiding this comment.
That's an awesome idea 💡. This is why they pay you the big bucks
strager
requested changes
Jan 21, 2024
plugin/vscode/test/vscode-tests.js
Outdated
| message, | ||
| })); | ||
| assert.deepStrictEqual(diags, [ | ||
| // use of undeclared variable 'undeclaredVariable' |
plugin/vscode/test/vscode-tests.js
Outdated
| }, | ||
| ] | ||
| ); | ||
| }, |
There was a problem hiding this comment.
I think you can add quick-lint-js.config stuff into the other three tests.
Alternatively, you could data-drive the tests (see line 24 for an existing example):
for (let testCase of [
{
fileName: 'hello.js',
content: 'undeclaredVariable',
englishMessage: 'use of undeclared variable: undeclaredVariable',
snarkyEnglishMessage: 'did you fail spelling class?',
},
{
fileName: 'quick-lint-js.config',
content: '{',
englishMessage: '...',
snarkyEnglishMessage: 'yeah, JSON sucks; try quick-lint-json',
},
]) {
tests = {
...tests,
[`enabling snarky re-lints (${testCase.fileName})`]: async ({ addCleanup }) => {
...
},
};
}
Summary: This commit refactors the global translator class into a variable injected into the VSCode workspace, and gives the workspace as an argument to QLJS_Lintable_Document. This refactor clears the way for adding snarky and language settings for VSCode
vegerot
changed the title
is "🖕🏾" profanity? |
Summary: It ticks me off 😠 how polite 😇 quick-lint is when I code. If I mess up 😬, I want it to tell me. Stop beating around the bush 🌳 and tell it to me like it is. 💯 Test plan: 📝 1. open TypeScript file with no errors in it ✅ 2. add an error ❌ 3. note how quick-lint tells you what the problem is like a sissy 😭 4. enable settings > quick-lint-js > snarky 😈 5. note how quick-lint is straight up with you. You suck. 🗑️ Closes quick-lint#1188
|
Landed as Git commit 86bb25f. |
strager
reviewed
Jan 25, 2024
| this->translator_.use_messages_from_source_code(); | ||
| } | ||
| this->qljs_documents_.for_each( | ||
| [this, is_snarky, env](::Napi::Value value) -> void { |
There was a problem hiding this comment.
Compiler was warning about is_snarky being an unused capture. I fixed it by using [&] instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(vscode): make quick-lint a jerk 🖕
Summary: It ticks me off 😠 how polite 😇 quick-lint is when I code. If I mess
up 😬, I want it to tell me. Stop beating around the bush 🌳 and tell it to me
like it is. 💯
Test plan: 📝
Closes #1188
Stack created with Sapling. Best reviewed with ReviewStack.