remove panic-on-drop in quinn_proto::Chunks

[abonander]

closes #1703
closes #1531

cc @djc

[abonander]

I might also recommend making the bool field of ShouldTransmit public to allow destructuring.

[djc]

I might also recommend making the bool field of ShouldTransmit public to allow destructuring.

Do you want to add a commit for this?

[abonander]

Sure, I just assumed there was a reason it wasn't already public.

[abonander]

Strictly speaking, it is a potential SemVer hazard if you foresee other fields being added later, e.g. total_bytes_read or something like that.

I don't really care either way. My implementation always checks poll_transmit() if there isn't one pending already.

[djc]

Then why would you recommend making the ShouldTransmit field public?

[abonander]

I did say "I might recommend", because some people might find it useful.

If ShouldTransmit was only ever intended to be a wrapper for a bool, making the field public makes sense from an API design standpoint.

I was just saying I don't care to die on this hill either way because I don't even use the type. 🤷