fix(scans) ds-531 Stop showing download button too soon #496
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scan Download button is displayed when scan has report_id field. However, report_id is assigned as soon as scan finished running, but before fingerprinting phase has finished. And it is not possible to download a scan before fingerprinting phase finished. Arguably this is API not playing very nice, but it's trivial for UI to wait for end_time field. That field is only present on scans that are all completed and reports can be downloaded. Also, fix typing warning in the same file. Relates to JIRA: DISCOVERY-531
mirekdlugosz
force-pushed
the
download-button-condition
branch
from
83e5c47
to
3c3a472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scan Download button is displayed when scan has report_id field. However, report_id is assigned as soon as scan finished running, but before fingerprinting phase has finished. And it is not possible to download a scan before fingerprinting phase finished.
Arguably this is API not playing very nice, but it's trivial for UI to wait for end_time field. That field is only present on scans that are all completed and reports can be downloaded.
Also, fix typing warning in the same file.
Relates to JIRA: DISCOVERY-531