Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update readme en/cn for jobs module features #5684

Merged
merged 14 commits into from
Jul 13, 2023

Conversation

MaikoTan
Copy link
Contributor

@MaikoTan MaikoTan commented Jul 11, 2023

This PR mainly do the following:

  • update the jobs module screenshot and so the features of it
  • update the jobs table for all the features currently
  • better wording for the jobs module description
  • fix several Chinese mistaken / poor translation
  • fix Chinese characters spacing with Latin characters following pangu.js

@MaikoTan MaikoTan marked this pull request as draft July 11, 2023 07:28
@MaikoTan MaikoTan changed the title docs: update readme cn translation docs: update readme jobs table en/cn Jul 11, 2023
@Echoring
Copy link
Contributor

Update description of jobs module. Also fix some pool translation.
I screenshot a new image of jobs module, for the image used now is too old and everything has changed.
Can anyone check is this image size appropriate?

@MaikoTan MaikoTan changed the title docs: update readme jobs table en/cn docs: update readme en/cn for jobs module features Jul 12, 2023
@MaikoTan MaikoTan marked this pull request as ready for review July 12, 2023 09:27
Copy link
Owner

@quisquous quisquous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new images, that's nice!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/zh-CN/README.md Outdated Show resolved Hide resolved
@MaikoTan
Copy link
Contributor Author

OK, it is good to merge now!

@quisquous quisquous merged commit 5d318b8 into quisquous:main Jul 13, 2023
3 checks passed
@quisquous
Copy link
Owner

Thank you!!

@MaikoTan MaikoTan deleted the docs/update-readme-cn branch July 13, 2023 00:45
github-actions bot pushed a commit that referenced this pull request Jul 13, 2023
…5684)

This PR mainly do the following:

- update the jobs module screenshot and so the features of it
- update the jobs table for all the features currently
- better wording for the jobs module description
- fix several Chinese mistaken / poor translation
- fix Chinese characters spacing with Latin characters following
[pangu.js](https://github.com/vinta/pangu.js)

---------

Co-authored-by: Echoring <[email protected]>
Co-authored-by: Adrienne Walker <[email protected]> 5d318b8
github-actions bot pushed a commit to FFXIVMacrology/cactbot-old that referenced this pull request Jul 13, 2023
…uisquous#5684)

This PR mainly do the following:

- update the jobs module screenshot and so the features of it
- update the jobs table for all the features currently
- better wording for the jobs module description
- fix several Chinese mistaken / poor translation
- fix Chinese characters spacing with Latin characters following
[pangu.js](https://github.com/vinta/pangu.js)

---------

Co-authored-by: Echoring <[email protected]>
Co-authored-by: Adrienne Walker <[email protected]> 5d318b8
github-actions bot pushed a commit to FFXIVMacrology/cactbot-old that referenced this pull request Jul 13, 2023
…uisquous#5684)

This PR mainly do the following:

- update the jobs module screenshot and so the features of it
- update the jobs table for all the features currently
- better wording for the jobs module description
- fix several Chinese mistaken / poor translation
- fix Chinese characters spacing with Latin characters following
[pangu.js](https://github.com/vinta/pangu.js)

---------

Co-authored-by: Echoring <[email protected]>
Co-authored-by: Adrienne Walker <[email protected]> 5d318b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants