Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: add durations for p12s white flame #5689

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Conversation

quisquous
Copy link
Owner

@quisquous quisquous commented Jul 13, 2023

Also adjust durations to reflect this.

From @valarnin's comment here: #5682 (comment)

A follow-up to this would be to adjust the calls about baiting to say "quick" or "delayed" or "very delayed" or something depending on how long the wait is.

Also adjust durations to reflect this.
@quisquous
Copy link
Owner Author

I'm pretty sure this worked, but I forgot to stream so want to give this another round of testing next week (or somebody else could too) before merging.

@Legends0
Copy link
Contributor

Legends0 commented Jul 14, 2023

I find it a bit confusing when it calls out the baits on # (since we also get numbers on head at that time but the numbers mean different hings). The initial thing I noticed is that it seems like a long TTS message. I get after looking at it it is calling the adds as they come down, but it is easily confused with your number if seeing it for the first time, especially when the prevailing pf strat seems to not need to know anything about the add's jump order.

@valarnin
Copy link
Collaborator

The main reason I wrote the initial version of this in the referenced PR is because I find it useful to know if the bait is fast or slow for 1/3 or 2/4 group.

@quisquous
Copy link
Owner Author

Yeah, I think my thought is that this could be included in the bait laser calls (both alert and info) whether it's fast or slow (or very slow). The infotext call about the order would probably be dropped.

@quisquous quisquous changed the title raidboss: add p12s white flame bait order raidboss: add durations for p12s white flame Jul 27, 2023
@quisquous
Copy link
Owner Author

I'm going to land this first version with just the durations and then will follow up with more text on each bait.

@quisquous quisquous merged commit 704cae5 into main Jul 27, 2023
7 checks passed
@quisquous quisquous deleted the valarnin_white_flame_bait branch July 27, 2023 17:23
github-actions bot pushed a commit that referenced this pull request Jul 27, 2023
From @valarnin's comment here:
#5682 (comment)

A follow-up to this would be to adjust the calls about baiting to say
"quick" or "delayed" or "very delayed" or something depending on how
long the wait is. 704cae5
github-actions bot pushed a commit that referenced this pull request Jul 27, 2023
From @valarnin's comment here:
#5682 (comment)

A follow-up to this would be to adjust the calls about baiting to say
"quick" or "delayed" or "very delayed" or something depending on how
long the wait is. 704cae5
quisquous added a commit that referenced this pull request Aug 11, 2023
Followup to #5689.

This also fixes a bug where the delays were incorrect because ongoing
add updates caused the trigger to re-fire.
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
…5747)

Followup to #5689.

This also fixes a bug where the delays were incorrect because ongoing
add updates caused the trigger to re-fire. dd45f2b
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
…5747)

Followup to #5689.

This also fixes a bug where the delays were incorrect because ongoing
add updates caused the trigger to re-fire. dd45f2b
github-actions bot pushed a commit to SiliconExarch/cactbot that referenced this pull request Aug 11, 2023
…uisquous#5747)

Followup to quisquous#5689.

This also fixes a bug where the delays were incorrect because ongoing
add updates caused the trigger to re-fire. dd45f2b
github-actions bot pushed a commit to SiliconExarch/cactbot that referenced this pull request Aug 11, 2023
…uisquous#5747)

Followup to quisquous#5689.

This also fixes a bug where the delays were incorrect because ongoing
add updates caused the trigger to re-fire. dd45f2b
github-actions bot pushed a commit to Veraticus/cactbot that referenced this pull request Aug 11, 2023
…uisquous#5747)

Followup to quisquous#5689.

This also fixes a bug where the delays were incorrect because ongoing
add updates caused the trigger to re-fire. dd45f2b
github-actions bot pushed a commit to Veraticus/cactbot that referenced this pull request Aug 11, 2023
…uisquous#5747)

Followup to quisquous#5689.

This also fixes a bug where the delays were incorrect because ongoing
add updates caused the trigger to re-fire. dd45f2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants