Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: Another Aloalo Island Normal & Savage #5909

Closed
wants to merge 10 commits into from
Closed

raidboss: Another Aloalo Island Normal & Savage #5909

wants to merge 10 commits into from

Conversation

kshman
Copy link
Contributor

@kshman kshman commented Nov 6, 2023

Sorry no Oopsy 😭

English only but, able to play on Japanese client
SImple triggers + timeline

@kshman kshman changed the title raidboss: Another Aloalo Island Normal & Savege raidboss: Another Aloalo Island Normal & Savage Nov 7, 2023
Copy link
Contributor

@xiashtra xiashtra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these non-damaging abilities would be better off marked as --sync-- or batched together with a duration so they don't clutter up the timeline.

ui/raidboss/data/06-ew/dungeon/another_aloalo_island.txt Outdated Show resolved Hide resolved
ui/raidboss/data/06-ew/dungeon/another_aloalo_island.txt Outdated Show resolved Hide resolved
ui/raidboss/data/06-ew/dungeon/another_aloalo_island.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@xiashtra xiashtra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing this PR, I've noticed a few issues:

  • Ketuduke Fluke Gale 2: incorrect call for location ("Go to 1/2 area")
  • Statice Pinwheeling Dartboard 2: incorrect call for color tile to stand on/tile swaps (it appears that the Bull's-eye 2 trigger isn't firing correctly and it is using the Bull's-eye 1 trigger instead)

Some other suggestions:

  • Kiwakin Sharp Strike: cleanse callout for bleed
  • Monk Hydroshot: callout each target for preparing targeted shields/mitigations/regens
  • Ketuduke Angry Seas: reminder call for second effect (stack/spread)
  • Islekeeper Gravity Force: use built-in "Stack on [x]" callout
  • Lala Planar Tactics: callout which numbers (1/2/3) the stacks are on
  • Lala Planar Tactics: the current "Mindhack: Left/Right" callout can be confusing; suggest using "Face Left/Right" instead
  • Lala Constructive Figure: call which side of the room the Golems spawn on
  • Lala Explosive Theorem: spread callout
  • Statice Pinwheeling Dartboard 2: callout which color tile has the floor dart

ui/raidboss/data/06-ew/dungeon/another_aloalo_island.ts Outdated Show resolved Hide resolved
ui/raidboss/data/06-ew/dungeon/another_aloalo_island.ts Outdated Show resolved Hide resolved
ui/raidboss/data/06-ew/dungeon/another_aloalo_island.ts Outdated Show resolved Hide resolved
ui/raidboss/data/06-ew/dungeon/another_aloalo_island.ts Outdated Show resolved Hide resolved
ui/raidboss/data/06-ew/dungeon/another_aloalo_island.ts Outdated Show resolved Hide resolved
ui/raidboss/data/06-ew/dungeon/another_aloalo_island.ts Outdated Show resolved Hide resolved
@kshman
Copy link
Contributor Author

kshman commented Nov 9, 2023

* Ketuduke Fluke Gale 2: incorrect call for location ("Go to 1/2 area")

I make option for strat selection. But I had no problems 😫

* Statice Pinwheeling Dartboard 2: incorrect call for color tile to stand on/tile swaps (it appears that the `Bull's-eye 2` trigger isn't firing correctly and it is using the `Bull's-eye 1` trigger instead)

Also I had no problems. Please let me know the strat you played.
It seems to be tested in diffent strat. I think.

Some other suggestions:

I'll fix it as long as I can 😭

Thank you for testing!

@xiashtra
Copy link
Contributor

xiashtra commented Nov 9, 2023

* Ketuduke Fluke Gale 2: incorrect call for location ("Go to 1/2 area")

I make option for strat selection. But I had no problems 😫

* Statice Pinwheeling Dartboard 2: incorrect call for color tile to stand on/tile swaps (it appears that the `Bull's-eye 2` trigger isn't firing correctly and it is using the `Bull's-eye 1` trigger instead)

Also I had no problems. Please let me know the strat you played. It seems to be tested in diffent strat. I think.

Some other suggestions:

I'll fix it as long as I can 😭

Thank you for testing!

It wasn't a strat difference issue, the triggers weren't firing properly in-game or when tested in the emulator. The Fluke Gale trigger appeared to be using stale data when the mechanic repeated (it was correct on the first use), and the Bull's Eye 2 trigger wasn't firing at all.

@kshman kshman closed this Nov 11, 2023
@xiashtra
Copy link
Contributor

There's some good work here, I wouldn't abandon it completely. At the very least, parts of it could be merged with what quisquous is working on in #5889 once they're done with their blind prog. It's just a bit awkward to collaborate while the project owner is avoiding spoilers.

@quisquous
Copy link
Owner

Yeah, I know it's incredibly awkward, thank you for your patience.

If xiashtra has read this through entirely and thinks this looks good and could be merged, I'd be happy to merge it without looking at it if you (either of you, both of you) would be willing to fix any bugs or complaints if they come up before I'm done with my very slow to schedule blind prog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants