Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding in MultiChannelPT and a central function for duration comparability test #535

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

terrorfisch
Copy link
Member

@terrorfisch terrorfisch commented May 11, 2020

As a first step I will factor out _as_expression and add a initial_value and final_value to PulseTemplate

Factored out central duration compability test in #590

TODO:

  • test
  • configure tolerance as user (how?)

@terrorfisch terrorfisch changed the title Add central function for duration comparability test Padding in MultiChannelPT and a central function for duration comparability test Aug 4, 2020
@coveralls
Copy link

coveralls commented Aug 4, 2020

Pull Request Test Coverage Report for Build 2187

  • 238 of 270 (88.15%) changed or added relevant lines in 11 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 84.27%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qupulse/pulses/arithmetic_pulse_template.py 9 10 90.0%
qupulse/utils/numeric.py 13 14 92.86%
qupulse/_program/waveforms.py 86 88 97.73%
qupulse/pulses/function_pulse_template.py 1 3 33.33%
qupulse/pulses/mapping_pulse_template.py 1 4 25.0%
qupulse/pulses/table_pulse_template.py 24 27 88.89%
qupulse/utils/sympy.py 4 8 50.0%
qupulse/pulses/multi_channel_pulse_template.py 67 83 80.72%
Files with Coverage Reduction New Missed Lines %
qupulse/pulses/table_pulse_template.py 1 96.56%
qupulse/utils/types.py 1 87.57%
Totals Coverage Status
Change from base Build 2175: -0.1%
Covered Lines: 6461
Relevant Lines: 7522

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants