Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme updated with qutip.devmajor and cupy instructions #18

Merged
merged 5 commits into from
Jul 12, 2021

Conversation

MrRobot2211
Copy link
Collaborator

@MrRobot2211 MrRobot2211 commented Jul 6, 2021

This updates the readme with an step by step explanation of how to install the unreleased version and required libraries, Just for adventurers.

See #14. About usage, maybe we should point to the data_layer documentation. In any case there is not much usage we can reap from it now, but I have a basic notebook with examples already is there a correct place to hang it?

@coveralls
Copy link

coveralls commented Jul 6, 2021

Pull Request Test Coverage Report for Build 1006562432

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.9%) to 82.432%

Files with Coverage Reduction New Missed Lines %
src/qutip_cupy/init.py 2 89.47%
Totals Coverage Status
Change from base Build 1003702665: -1.9%
Covered Lines: 61
Relevant Lines: 74

💛 - Coveralls

@nwlambert
Copy link
Member

For what its worth, this worked without much fuss in windows 👍

README.md Outdated

Now you can safely install `qutip-cupy`

- python -mpip install https://github.com/qutip/qutip-cupy.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this needs a git+ prefix?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@MrRobot2211 MrRobot2211 requested a review from hodgestar July 7, 2021 12:47
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
MrRobot2211 and others added 2 commits July 7, 2021 17:43
redundant cudatoolkit installation

Co-authored-by: Leo Fang <[email protected]>
@hodgestar hodgestar merged commit 4b7af03 into qutip:main Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants