Bosonic Fitting #72
Draft
Bosonic Fitting #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmenczel
reviewed
Nov 16, 2023
There was a problem hiding this comment.
Overall it's nice to see that the new fitting functionality makes everything here much simpler! I went through the changes and had a few questions, see the comments below. I'm not making any comments on the main part of the fitting code yet since I expect that the qutip interface will still change a lot.
Comment on lines
73
to
76
|
|
||
| ## Helper functions | ||
|
|
||
| Let's define some helper functions for plotting results and timing how long operations take: | ||
|
|
||
| ```{code-cell} ipython3 | ||
| def coth(x): | ||
| """ Vectorized hyperbolic cotangent of x. """ | ||
| return 1. / np.tanh(x) | ||
| ``` | ||
|
|
||
| ```{code-cell} ipython3 | ||
| def plot_result_expectations(plots, axes=None): | ||
| """ Plot the expectation values of operators as functions of time. | ||
|
|
||
| Each plot in plots consists of (solver_result, | ||
| measurement_operation, color, label). | ||
| """ | ||
| if axes is None: | ||
| fig, axes = plt.subplots(1, 1, sharex=True, figsize=(8, 8)) | ||
| fig_created = True | ||
| else: | ||
| fig = None | ||
| fig_created = False | ||
|
|
||
| # add kw arguments to each plot if missing | ||
| plots = [p if len(p) == 5 else p + ({},) for p in plots] | ||
| for result, m_op, color, label, kw in plots: | ||
| exp = np.real(expect(result.states, m_op)) | ||
| kw.setdefault("linewidth", 2) | ||
| if color == 'rand': | ||
| axes.plot( | ||
| result.times, exp, | ||
| c=np.random.rand(3,), label=label, **kw, | ||
| ) | ||
| else: | ||
| axes.plot(result.times, exp, color, label=label, **kw) | ||
|
|
||
| if fig_created: | ||
| axes.legend(loc=0, fontsize=12) | ||
| axes.set_xlabel("t", fontsize=28) | ||
|
|
||
| return fig | ||
| ``` | ||
|
|
||
| ```{code-cell} ipython3 | ||
| @contextlib.contextmanager | ||
| def timer(label): | ||
| """ Simple utility for timing functions: | ||
|
|
||
| with timer("name"): | ||
| ... code to time ... | ||
| """ | ||
| start = time.time() | ||
| yield | ||
| end = time.time() | ||
| print(f"{label}: {end - start}") | ||
| ``` | ||
| Let's define some helper functions for plotting the resutls |
There was a problem hiding this comment.
Github is formatting this weirdly, I meant to delete lines 73-76 since there are no helper functions anymore
Co-authored-by: Paul <[email protected]>
|
It seems that you have added some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the HEOM tutorials according to the corresponding PR on the qutip master branch