Add another link. #712
qwandorAnnotations
6 warnings
|
build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
manual implementation of `Option::map`:
src/importers/icalendar.rs#L222
warning: manual implementation of `Option::map`
--> src/importers/icalendar.rs:222:12
|
222 | } else if let Some(attendee) = event
| ____________^
223 | | .multi_properties()
224 | | .get("ATTENDEE")
225 | | .and_then(|attendees| attendees.first())
... |
229 | | None
230 | | };
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
= note: `#[warn(clippy::manual_map)]` on by default
help: try
|
222 ~ } else { event
223 + .multi_properties()
224 + .get("ATTENDEE")
225 ~ .and_then(|attendees| attendees.first()).map(|attendee| attendee.value().to_owned()) };
|
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
src/importers/icalendar/cdss.rs#L184
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/importers/icalendar/cdss.rs:184:5
|
184 | / match (event.city.as_str(), event.state.as_deref()) {
185 | | ("Henrico", Some("VA")) => {
186 | | event.city = "Richmond".to_string();
187 | | }
188 | | _ => {}
189 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
help: try
|
184 ~ if let ("Henrico", Some("VA")) = (event.city.as_str(), event.state.as_deref()) {
185 + event.city = "Richmond".to_string();
186 + }
|
|
|
accessing first element with `location_parts.get(0)`:
src/importers/icalendar/cdss.rs#L116
warning: accessing first element with `location_parts.get(0)`
--> src/importers/icalendar/cdss.rs:116:17
|
116 | location_parts.get(0).cloned().unwrap_or_default(),
| ^^^^^^^^^^^^^^^^^^^^^ help: try: `location_parts.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
|
|
you seem to be trying to use `match` for an equality check. Consider using `if`:
src/importers/icalendar/balfolknl.rs#L164
warning: you seem to be trying to use `match` for an equality check. Consider using `if`
--> src/importers/icalendar/balfolknl.rs:164:9
|
164 | / match event.city.as_str() {
165 | | "Lent" => event.city = "Nijmegen".to_string(),
166 | | _ => {}
167 | | }
| |_________^ help: try: `if event.city.as_str() == "Lent" { event.city = "Nijmegen".to_string() }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/importers/icalendar/balfolknl.rs#L162
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/importers/icalendar/balfolknl.rs:162:35
|
162 | event.name = shorten_name(&raw_name);
| ^^^^^^^^^ help: change this to: `raw_name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
debian-packages
|
3.57 MB |
|