Skip to content

Bump clap from 4.5.23 to 4.5.24 (#493) #1511

Bump clap from 4.5.23 to 4.5.24 (#493)

Bump clap from 4.5.23 to 4.5.24 (#493) #1511

GitHub Actions / clippy succeeded Jan 8, 2025 in 0s

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check warning on line 230 in src/importers/icalendar.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual implementation of `Option::map`

warning: manual implementation of `Option::map`
   --> src/importers/icalendar.rs:222:12
    |
222 |       } else if let Some(attendee) = event
    |  ____________^
223 | |         .multi_properties()
224 | |         .get("ATTENDEE")
225 | |         .and_then(|attendees| attendees.first())
...   |
229 | |         None
230 | |     };
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
    = note: `#[warn(clippy::manual_map)]` on by default
help: try
    |
222 ~     } else { event
223 +         .multi_properties()
224 +         .get("ATTENDEE")
225 ~         .and_then(|attendees| attendees.first()).map(|attendee| attendee.value().to_owned()) };
    |

Check warning on line 189 in src/importers/icalendar/cdss.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
   --> src/importers/icalendar/cdss.rs:184:5
    |
184 | /     match (event.city.as_str(), event.state.as_deref()) {
185 | |         ("Henrico", Some("VA")) => {
186 | |             event.city = "Richmond".to_string();
187 | |         }
188 | |         _ => {}
189 | |     }
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
help: try
    |
184 ~     if let ("Henrico", Some("VA")) = (event.city.as_str(), event.state.as_deref()) {
185 +         event.city = "Richmond".to_string();
186 +     }
    |

Check warning on line 116 in src/importers/icalendar/cdss.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

accessing first element with `location_parts.get(0)`

warning: accessing first element with `location_parts.get(0)`
   --> src/importers/icalendar/cdss.rs:116:17
    |
116 |                 location_parts.get(0).cloned().unwrap_or_default(),
    |                 ^^^^^^^^^^^^^^^^^^^^^ help: try: `location_parts.first()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
    = note: `#[warn(clippy::get_first)]` on by default

Check warning on line 147 in src/importers/icalendar/balfolknl.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you seem to be trying to use `match` for an equality check. Consider using `if`

warning: you seem to be trying to use `match` for an equality check. Consider using `if`
   --> src/importers/icalendar/balfolknl.rs:144:9
    |
144 | /         match event.city.as_str() {
145 | |             "Lent" => event.city = "Nijmegen".to_string(),
146 | |             _ => {}
147 | |         }
    | |_________^ help: try: `if event.city.as_str() == "Lent" { event.city = "Nijmegen".to_string() }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
    = note: `#[warn(clippy::single_match)]` on by default

Check warning on line 142 in src/importers/icalendar/balfolknl.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/importers/icalendar/balfolknl.rs:142:35
    |
142 |         event.name = shorten_name(&raw_name);
    |                                   ^^^^^^^^^ help: change this to: `raw_name`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default